Code review comment for lp:~makyo/juju-gui/endpoints-once

Revision history for this message
Brad Crittenden (bac) wrote :

Looks good but I've suggested a code simplification. No need to
re-review.

https://codereview.appspot.com/6858099/diff/5001/app/app.js
File app/app.js (right):

https://codereview.appspot.com/6858099/diff/5001/app/app.js#newcode325
app/app.js:325:
.some() returns true or false so I think you could just do:

var updateNeeded = this.db.services.some(function(service) {
          return (self.serviceEndpoints[service.get('id')] ===
undefined)});

https://codereview.appspot.com/6858099/

« Back to merge proposal