Missing a unit test.
Else looks good.
Merge with changes.
Thanks
https://codereview.appspot.com/6858099/diff/1/app/app.js File app/app.js (right):
https://codereview.appspot.com/6858099/diff/1/app/app.js#newcode314 app/app.js:314: if (!Y.Lang.isValue(this.serviceEndpoints)) { i'd suggest moving this to the initializer and dropping the conditional instead of lazy value initialization.
https://codereview.appspot.com/6858099/diff/1/app/app.js#newcode323 app/app.js:323: return updateNeeded; return is extraneous here
https://codereview.appspot.com/6858099/
« Back to merge proposal
Missing a unit test.
Else looks good.
Merge with changes.
Thanks
https:/ /codereview. appspot. com/6858099/ diff/1/ app/app. js
File app/app.js (right):
https:/ /codereview. appspot. com/6858099/ diff/1/ app/app. js#newcode314 isValue( this.serviceEnd points) ) {
app/app.js:314: if (!Y.Lang.
i'd suggest moving this to the initializer and dropping the conditional
instead of lazy value initialization.
https:/ /codereview. appspot. com/6858099/ diff/1/ app/app. js#newcode323
app/app.js:323: return updateNeeded;
return is extraneous here
https:/ /codereview. appspot. com/6858099/