Code review comment for lp:~makyo/juju-gui/consistent-health-graph

Revision history for this message
Benjamin Saller (bcsaller) wrote :

LGTM

https://codereview.appspot.com/6718048/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6718048/diff/1/app/views/environment.js#newcode784
app/views/environment.js:784: });
This looks fine to me, can we however be sure those are the only three
states bubbling to this layer? I know that is supposed to be the case,
but should these ever come out of sync having a fallback value here
might make sense.

Probably fine for now though

https://codereview.appspot.com/6718048/

« Back to merge proposal