https://codereview.appspot.com/6736051/diff/3002/app/views/environment.js#newcode1489
app/views/environment.js:1489: // Create a relation with the only
available endpoint.
On 2012/10/19 21:48:58, hazmat wrote:
> i think this is better structured with the second clause upfront with
a return
> at the end of the block, and then the first block can become dedented.
Cards created in FrontPage.
https:/ /codereview. appspot. com/6736051/ diff/3002/ app/views/ environment. js environment. js (right):
File app/views/
https:/ /codereview. appspot. com/6736051/ diff/3002/ app/views/ environment. js#newcode1076 environment. js:1076: .ambiguousAddRe lationTest( endpoint, self, ointCheck
app/views/
rect);
On 2012/10/19 21:48:58, hazmat wrote:
> i'd suggest renaming this method, just to avoid the test parlance
outside of
> unit testing. maybe... addRelationEndp
Done.
https:/ /codereview. appspot. com/6736051/ diff/3002/ app/views/ environment. js#newcode1476 environment. js:1476: // Add a cancel item.
app/views/
On 2012/10/19 21:48:58, hazmat wrote:
> The cancel item is better at the end, preferably styled as a dialog
cancel
> button or with red/differentiating text.
Done.
https:/ /codereview. appspot. com/6736051/ diff/3002/ app/views/ environment. js#newcode1477 environment. js:1477: menu.one( '.cancel' ).on('click' ,
app/views/
function(evt) {
On 2012/10/19 21:48:58, hazmat wrote:
> The menu should also cancel on click outside, the same way the invalid
target
> fadeout works.
Done.
https:/ /codereview. appspot. com/6736051/ diff/3002/ app/views/ environment. js#newcode1483 environment. js:1483: var tr = view.zoom. translate( ),
app/views/
On 2012/10/19 21:48:58, hazmat wrote:
> like the service menu this should also track roughly with the service
container
> on zoom/pan (the menu shouldn't resize though on zoom).
Done.
https:/ /codereview. appspot. com/6736051/ diff/3002/ app/views/ environment. js#newcode1489 environment. js:1489: // Create a relation with the only
app/views/
available endpoint.
On 2012/10/19 21:48:58, hazmat wrote:
> i think this is better structured with the second clause upfront with
a return
> at the end of the block, and then the first block can become dedented.
Done.
https:/ /codereview. appspot. com/6736051/