A test was added as well, but rather than just testing whether or not subordinates had been placed properly, it tests that all services have been placed properly.
https://codereview.appspot.com/6856067/diff/1/app/views/environment.js File app/views/environment.js (right):
https://codereview.appspot.com/6856067/diff/1/app/views/environment.js#newcode323 app/views/environment.js:323: }) On 2012/11/20 14:50:48, bac wrote: > maybe this would be more readable:
> min(1, d.unit_count)
Thanks! Did Math.max(d.unit_count, 1); (since we want 1 or higher)
https://codereview.appspot.com/6856067/
« Back to merge proposal
A test was added as well, but rather than just testing whether or not
subordinates had been placed properly, it tests that all services have
been placed properly.
https:/ /codereview. appspot. com/6856067/ diff/1/ app/views/ environment. js environment. js (right):
File app/views/
https:/ /codereview. appspot. com/6856067/ diff/1/ app/views/ environment. js#newcode323 environment. js:323: })
app/views/
On 2012/11/20 14:50:48, bac wrote:
> maybe this would be more readable:
> min(1, d.unit_count)
Thanks! Did Math.max( d.unit_ count, 1); (since we want 1 or higher)
https:/ /codereview. appspot. com/6856067/