Merge lp:~makyo/juju-gui/add-rel-touch-1166819 into lp:juju-gui/experimental

Proposed by Madison Scott-Clary
Status: Merged
Merged at revision: 536
Proposed branch: lp:~makyo/juju-gui/add-rel-touch-1166819
Merge into: lp:juju-gui/experimental
Diff against target: 19 lines (+4/-2)
1 file modified
app/views/topology/service.js (+4/-2)
To merge this branch: bzr merge lp:~makyo/juju-gui/add-rel-touch-1166819
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+158180@code.launchpad.net

Description of the change

Trivial: add relation works with touch.

https://codereview.appspot.com/8628044/

To post a comment you must log in.
Revision history for this message
Madison Scott-Clary (makyo) wrote :

Reviewers: mp+158180_code.launchpad.net,

Message:
Please take a look.

Description:
Trivial: add relation works with touch.

https://code.launchpad.net/~makyo/juju-gui/add-rel-touch-1166819/+merge/158180

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/8628044/

Affected files:
   A [revision details]
   M app/views/topology/service.js

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: app/views/topology/service.js
=== modified file 'app/views/topology/service.js'
--- app/views/topology/service.js 2013-04-09 21:46:28 +0000
+++ app/views/topology/service.js 2013-04-10 17:57:03 +0000
@@ -377,11 +377,13 @@
      },

      dragend: function(box, self) {
+ var topo = self.get('component');
        if (box.tapped) {
          box.tapped = false;
- return;
+ if (!topo.buildingRelation) {
+ return;
+ }
        }
- var topo = self.get('component');
        if (topo.buildingRelation) {
          topo.ignoreServiceClick = true;
          topo.fire('addRelationDragEnd');

Revision history for this message
Gary Poster (gary) wrote :

LGTM without qa. Lemme know if you want qa before landing.

https://codereview.appspot.com/8628044/

Revision history for this message
Madison Scott-Clary (makyo) wrote :

*** Submitted:

Trivial: add relation works with touch.

R=gary.poster
CC=
https://codereview.appspot.com/8628044

https://codereview.appspot.com/8628044/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/views/topology/service.js'
2--- app/views/topology/service.js 2013-04-09 21:46:28 +0000
3+++ app/views/topology/service.js 2013-04-10 18:00:33 +0000
4@@ -377,11 +377,13 @@
5 },
6
7 dragend: function(box, self) {
8+ var topo = self.get('component');
9 if (box.tapped) {
10 box.tapped = false;
11- return;
12+ if (!topo.buildingRelation) {
13+ return;
14+ }
15 }
16- var topo = self.get('component');
17 if (topo.buildingRelation) {
18 topo.ignoreServiceClick = true;
19 topo.fire('addRelationDragEnd');

Subscribers

People subscribed via source and target branches