Merge lp:~mairin/postorius/mairin-1 into lp:postorius

Proposed by mairin
Status: Merged
Merged at revision: 149
Proposed branch: lp:~mairin/postorius/mairin-1
Merge into: lp:postorius
Diff against target: 13 lines (+1/-1)
1 file modified
src/postorius/templates/postorius/users/new.html (+1/-1)
To merge this branch: bzr merge lp:~mairin/postorius/mairin-1
Reviewer Review Type Date Requested Status
Terri Approve
Review via email: mp+189476@code.launchpad.net

Commit message

Minor HTML fix for new users form

This change fixes a minor issue in the new users form where most of the form fields are outside of the "field" div. From reading fieldset_forms.py it looks like all of the form fields are meant to be inside of this div. I'm trying to pretty up the form stylistically and need this change on this form to do so.

Description of the change

This change fixes a minor issue in the new users form where most of the form fields are outside of the "field" div. From reading fieldset_forms.py it looks like all of the form fields are meant to be inside of this div. I'm trying to pretty up the form stylistically and need this change on this form to do so.

Specifically, this fixes the new users form. If I find this issue on other forms I'll fix those too in separate merge requests.

To post a comment you must log in.
Revision history for this message
Terri (terriko) wrote :

looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/postorius/templates/postorius/users/new.html'
--- src/postorius/templates/postorius/users/new.html 2013-07-05 11:05:45 +0000
+++ src/postorius/templates/postorius/users/new.html 2013-10-05 16:39:25 +0000
@@ -9,8 +9,8 @@
9 {% endif %}9 {% endif %}
1010
11 <form action="{% url 'user_new' %}" method="post" class="well"> {% csrf_token %}11 <form action="{% url 'user_new' %}" method="post" class="well"> {% csrf_token %}
12 {{ form.as_p }}
13 <div class="field">12 <div class="field">
13 {{ form.as_p }}
14 <button class="btn btn-success" type="submit">{% trans "Create User" %}</button>14 <button class="btn btn-success" type="submit">{% trans "Create User" %}</button>
15 </div>15 </div>
16 </form>16 </form>

Subscribers

People subscribed via source and target branches