OpenLP

Merge lp:~mahfiaz/openlp/author-delete-button-not-active-in-edit-dialog into lp:openlp

  1. author-delete-button-not-active-in-edit-dialog
  2. Merge into trunk
Proposed by mahfiaz
Status: Rejected
Rejected by: Andreas Preikschat
Proposed branch: lp:~mahfiaz/openlp/author-delete-button-not-active-in-edit-dialog
Merge into: lp:openlp
Diff against target: 13 lines (+2/-1)
1 file modified
openlp/plugins/songs/forms/editsongform.py (+2/-1)
To merge this branch: bzr merge lp:~mahfiaz/openlp/author-delete-button-not-active-in-edit-dialog
Reviewer Review Type Date Requested Status
Andreas Preikschat (community) Needs Resubmitting
Tim Bentley Needs Fixing
Review via email: mp+183329@code.launchpad.net

This proposal supersedes a proposal from 2013-08-24.

Description of the change

Fixed a tiny glitch, remove author button became always disabled even if not needed to.

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote : Posted in a previous version of this proposal

Would approve it if it had a test.

review: Needs Fixing
Revision history for this message
Tim Bentley (trb143) wrote : Posted in a previous version of this proposal

Please resubmit due to the age of this request and additionally it will need converting to Python 3 as on 1/9/2013 truck will be converted.

review: Needs Resubmitting
Revision history for this message
Tim Bentley (trb143) wrote :

Please resubmit as this is not compatible with python3 as tests are required for all core changes.

review: Needs Fixing
Revision history for this message
Andreas Preikschat (googol-deactivatedaccount) wrote :

Please resubmit by the end of 2013.

review: Needs Resubmitting

Unmerged revisions

2287. By mahfiaz

Make remove authors button enabled until the last author remains.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/plugins/songs/forms/editsongform.py'
2--- openlp/plugins/songs/forms/editsongform.py 2013-08-31 08:56:21 +0000
3+++ openlp/plugins/songs/forms/editsongform.py 2013-08-31 15:20:47 +0000
4@@ -538,7 +538,8 @@
5 """
6 Remove the author from the list when the delete button is clicked.
7 """
8- self.author_remove_button.setEnabled(False)
9+ if self.authors_list_view.count() <= 2:
10+ self.author_remove_button.setEnabled(False)
11 item = self.authors_list_view.currentItem()
12 row = self.authors_list_view.row(item)
13 self.authors_list_view.takeItem(row)