Thanks for the changes. It's really nice to have new applications such as
evolution included in the mago distribution.
There's one little thing that I would change to make the regular expression that
takes care of extracting the LDTP version more robust, just in case there are
multiple digits in the version string in the future (i.e. ldtp-99.99.99):
< pattern = re.compile("ldtp-(\d\.\d\.\d).*")
< m = pattern.match(version)
> pattern = re.compile("ldtp-(\d+\.\d+\.\d+)")
> m = pattern.search(version)
Best regards,
Javier
Ara Pulido wrote:
> Ara Pulido has proposed merging lp:~mago-contributors/mago/evolution into lp:mago.
>
> Requested reviews:
> Mago Contributors (mago-contributors)
>
> Two major things:
>
> 1) Added basic tests for evolution (and notify-osd / message-indicator cross tests)
> 2) LDTP broke the API in version 1.6, and the imagacapture signature is different. Added a method to keep backwards compatibility.
>
Hello,
Thanks for the changes. It's really nice to have new applications such as
evolution included in the mago distribution.
There's one little thing that I would change to make the regular expression that
takes care of extracting the LDTP version more robust, just in case there are
multiple digits in the version string in the future (i.e. ldtp-99.99.99):
< pattern = re.compile( "ldtp-( \d\.\d\ .\d).*" ) match(version)
< m = pattern.
> pattern = re.compile( "ldtp-( \d+\.\d+ \.\d+)" ) search( version)
> m = pattern.
Best regards,
Javier
Ara Pulido wrote:
> Ara Pulido has proposed merging lp:~mago-contributors/mago/evolution into lp:mago.
>
> Requested reviews:
> Mago Contributors (mago-contributors)
>
> Two major things:
>
> 1) Added basic tests for evolution (and notify-osd / message-indicator cross tests)
> 2) LDTP broke the API in version 1.6, and the imagacapture signature is different. Added a method to keep backwards compatibility.
>