Code review comment for lp:~madteam/mg5amcnlo/madevent_output
Revision history for this message
| Olivier Mattelaer (olivier-mattelaer) wrote | # |
review:
Needs Information
(suggestion)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi Johan,
I've still not work intensively on the reviewing. But this is a first comment.
In the files export_v4, you have define a lot of long string.
I think that it will be more clear if you put those files content in some files in the
Template_file directory.
I suggest to create one files for each of those long string (with the associate name of mg4)
and then load them via the string.Template class.
Olivier
PS: Off course this is only a suggestion.
In this sense this breaks some rules of how to
Why do not use the Templates