Merge lp:~madsa/switchboard-plug-keyboard/switchboard-plug-keyboard-fix-1586631 into lp:~elementary-pantheon/switchboard-plug-keyboard/trunk

Proposed by Matt Spaulding
Status: Merged
Approved by: Cody Garver
Approved revision: 469
Merged at revision: 470
Proposed branch: lp:~madsa/switchboard-plug-keyboard/switchboard-plug-keyboard-fix-1586631
Merge into: lp:~elementary-pantheon/switchboard-plug-keyboard/trunk
Diff against target: 52 lines (+23/-4)
1 file modified
src/keyboard.vala (+23/-4)
To merge this branch: bzr merge lp:~madsa/switchboard-plug-keyboard/switchboard-plug-keyboard-fix-1586631
Reviewer Review Type Date Requested Status
Santiago (community) code Approve
Review via email: mp+306728@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Santiago (santileortiz) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/keyboard.vala'
--- src/keyboard.vala 2016-06-28 23:03:04 +0000
+++ src/keyboard.vala 2016-09-26 03:11:29 +0000
@@ -1,5 +1,6 @@
1public class Pantheon.Keyboard.Plug : Switchboard.Plug {1public class Pantheon.Keyboard.Plug : Switchboard.Plug {
2 Gtk.Grid grid;2 Gtk.Grid grid;
3 Gtk.Stack stack;
34
4 public Plug () {5 public Plug () {
5 Object (category: Category.HARDWARE,6 Object (category: Category.HARDWARE,
@@ -13,7 +14,7 @@
13 if (grid == null) {14 if (grid == null) {
14 grid = new Gtk.Grid ();15 grid = new Gtk.Grid ();
15 grid.margin = 12;16 grid.margin = 12;
16 var stack = new Gtk.Stack ();17 stack = new Gtk.Stack ();
17 var stack_switcher = new Gtk.StackSwitcher ();18 var stack_switcher = new Gtk.StackSwitcher ();
18 stack_switcher.set_stack (stack);19 stack_switcher.set_stack (stack);
19 stack_switcher.halign = Gtk.Align.CENTER;20 stack_switcher.halign = Gtk.Align.CENTER;
@@ -38,12 +39,30 @@
38 }39 }
3940
40 public override void search_callback (string location) {41 public override void search_callback (string location) {
4142 switch (location) {
43 default:
44 case "Shortcuts":
45 stack.visible_child_name = "shortcuts";
46 break;
47 case "Behavior":
48 stack.visible_child_name = "behavior";
49 break;
50 case "Layout":
51 stack.visible_child_name = "layout";
52 break;
53 }
42 }54 }
4355
44 // 'search' returns results like ("Keyboard → Behavior → Duration", "keyboard<sep>behavior")56 // 'search' returns results like ("Keyboard → Behavior → Duration", "keyboard<sep>behavior")
45 public override async Gee.TreeMap<string, string> search (string search) {57 public override async Gee.TreeMap<string, string> search (string search) {
46 return new Gee.TreeMap<string, string> (null, null);58 var search_results = new Gee.TreeMap<string, string> ((GLib.CompareDataFunc<string>)strcmp, (Gee.EqualDataFunc<string>)str_equal);
59 search_results.set ("%s → %s".printf (display_name, _("Shortcuts")), "Shortcuts");
60 search_results.set ("%s → %s".printf (display_name, _("Repeat Keys")), "Behavior");
61 search_results.set ("%s → %s".printf (display_name, _("Cursor Blinking")), "Behavior");
62 search_results.set ("%s → %s".printf (display_name, _("Switch layout")), "Layout");
63 search_results.set ("%s → %s".printf (display_name, _("Compose Key")), "Layout");
64 search_results.set ("%s → %s".printf (display_name, _("Caps Lock behavior")), "Layout");
65 return search_results;
47 }66 }
48}67}
4968

Subscribers

People subscribed via source and target branches

to all changes: