Merge lp:~madsa/switchboard-plug-keyboard/switchboard-plug-keyboard-fix-1586631 into lp:~elementary-pantheon/switchboard-plug-keyboard/trunk

Proposed by Matt Spaulding
Status: Merged
Approved by: Cody Garver
Approved revision: 469
Merged at revision: 470
Proposed branch: lp:~madsa/switchboard-plug-keyboard/switchboard-plug-keyboard-fix-1586631
Merge into: lp:~elementary-pantheon/switchboard-plug-keyboard/trunk
Diff against target: 52 lines (+23/-4)
1 file modified
src/keyboard.vala (+23/-4)
To merge this branch: bzr merge lp:~madsa/switchboard-plug-keyboard/switchboard-plug-keyboard-fix-1586631
Reviewer Review Type Date Requested Status
Santiago (community) code Approve
Review via email: mp+306728@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Santiago (santileortiz) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/keyboard.vala'
2--- src/keyboard.vala 2016-06-28 23:03:04 +0000
3+++ src/keyboard.vala 2016-09-26 03:11:29 +0000
4@@ -1,5 +1,6 @@
5 public class Pantheon.Keyboard.Plug : Switchboard.Plug {
6- Gtk.Grid grid;
7+ Gtk.Grid grid;
8+ Gtk.Stack stack;
9
10 public Plug () {
11 Object (category: Category.HARDWARE,
12@@ -13,7 +14,7 @@
13 if (grid == null) {
14 grid = new Gtk.Grid ();
15 grid.margin = 12;
16- var stack = new Gtk.Stack ();
17+ stack = new Gtk.Stack ();
18 var stack_switcher = new Gtk.StackSwitcher ();
19 stack_switcher.set_stack (stack);
20 stack_switcher.halign = Gtk.Align.CENTER;
21@@ -38,12 +39,30 @@
22 }
23
24 public override void search_callback (string location) {
25-
26+ switch (location) {
27+ default:
28+ case "Shortcuts":
29+ stack.visible_child_name = "shortcuts";
30+ break;
31+ case "Behavior":
32+ stack.visible_child_name = "behavior";
33+ break;
34+ case "Layout":
35+ stack.visible_child_name = "layout";
36+ break;
37+ }
38 }
39
40 // 'search' returns results like ("Keyboard → Behavior → Duration", "keyboard<sep>behavior")
41 public override async Gee.TreeMap<string, string> search (string search) {
42- return new Gee.TreeMap<string, string> (null, null);
43+ var search_results = new Gee.TreeMap<string, string> ((GLib.CompareDataFunc<string>)strcmp, (Gee.EqualDataFunc<string>)str_equal);
44+ search_results.set ("%s → %s".printf (display_name, _("Shortcuts")), "Shortcuts");
45+ search_results.set ("%s → %s".printf (display_name, _("Repeat Keys")), "Behavior");
46+ search_results.set ("%s → %s".printf (display_name, _("Cursor Blinking")), "Behavior");
47+ search_results.set ("%s → %s".printf (display_name, _("Switch layout")), "Layout");
48+ search_results.set ("%s → %s".printf (display_name, _("Compose Key")), "Layout");
49+ search_results.set ("%s → %s".printf (display_name, _("Caps Lock behavior")), "Layout");
50+ return search_results;
51 }
52 }
53

Subscribers

People subscribed via source and target branches

to all changes: