Merge lp:~madjar/wikkid/plugin into lp:wikkid

Proposed by Georges Dubus
Status: Merged
Merged at revision: 45
Proposed branch: lp:~madjar/wikkid/plugin
Merge into: lp:wikkid
Diff against target: 35 lines (+12/-8)
1 file modified
plugin/commands.py (+12/-8)
To merge this branch: bzr merge lp:~madjar/wikkid/plugin
Reviewer Review Type Date Requested Status
Wikkid Hackers Pending
Review via email: mp+28339@code.launchpad.net

Description of the change

Updated the plugin, so that it works again after the transition from twisted to webbob.

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

On Thu, 24 Jun 2010 06:39:53 you wrote:
> Georges Dubus has proposed merging lp:~madjar/wikkid/plugin into lp:wikkid.
>
> Requested reviews:
> Wikkid Hackers (wikkid)
>
>
> Updated the plugin, so that it works again after the transition from
> twisted to webbob.

Ah, thanks. That completely slipped my mind. Is there any way we could add a
test for this?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugin/commands.py'
--- plugin/commands.py 2010-05-21 09:16:54 +0000
+++ plugin/commands.py 2010-06-23 18:39:52 +0000
@@ -6,10 +6,9 @@
66
7from bzrlib.workingtree import WorkingTree7from bzrlib.workingtree import WorkingTree
88
9from wikkid.app import WikkidApp
9from wikkid.filestore.bzr import FileStore10from wikkid.filestore.bzr import FileStore
10from wikkid.model.factory import ResourceFactory11from wikkid.user.bzr import LocalBazaarUserMiddleware
11from wikkid.twistedserver import TwistedServer
12from wikkid.user.bzr import UserFactory
1312
14DEFAULT_PORT = 808013DEFAULT_PORT = 8080
1514
@@ -42,8 +41,13 @@
42 working_tree = WorkingTree.open(branch)41 working_tree = WorkingTree.open(branch)
43 logger.info('Using: %s', working_tree)42 logger.info('Using: %s', working_tree)
44 filestore = FileStore(working_tree)43 filestore = FileStore(working_tree)
45 server = TwistedServer(44
46 ResourceFactory(filestore),45 app = WikkidApp(filestore)
47 UserFactory(working_tree.branch),46 app = LocalBazaarUserMiddleware(app, working_tree.branch)
48 port=port)47 from wsgiref.simple_server import make_server
49 server.run()48 httpd = make_server('localhost', port, app)
49 logger.info('Serving on http://localhost:%s', port)
50 try:
51 httpd.serve_forever()
52 except KeyboardInterrupt:
53 logger.info('Done.')

Subscribers

People subscribed via source and target branches