Code review comment for lp:~madjar/wikkid/plugin

Revision history for this message
Barry Warsaw (barry) wrote :

Looks pretty reasonable. What I'd probably change in the setup.py though is to use some setuptools helpers instead of listing the packages explicitly. Also, you might want to include distribute_setup.py in the top level directory to get all the distribute goodness.

e.g.

from distribute_setup import use_setuptools
use_setuptools()
from setuptools import setup, find_packages

setup(
    ...
    packages=find_packages(),
    ...
    )

Distribute (comes on Ubuntu in python-setuptools) gives lots of nice benefits, such as running the test suite via 'python setup.py test', and automatic 2to3 running (once you're Python 3 or Python 2.6 -3 compatible).

« Back to merge proposal