Code review comment for lp:~madjar/wikkid/plugin

On Thu, 20 May 2010 23:19:57 you wrote:
> > What is the Manifest file for?
>
> It's a list of the files that should be included in the source distribution
> (when running install.py sdist) and that are not already included as
> python modules.

OK, cool. Can we get a new line at the end of the file?

> > Also if it is going to attempt to install the file 'run.py' into
> > /usr/local/bin, we should rename it.
>
> Yes, obviously. Any suggestion for the name ? Would "wikkid" be good ?

Yes, I think that is a reasonable starting place.

> > Do you see any point in distributing the test directories? Is it normal
> > to do so?
>
> running "find /usr/lib/python2.6/site-packages -name *test*" should
> convince you that's the usual thing to do. That's useful when, for
> example, the development version works, but stop working when you install
> it. The test will help you in that case. Also, the command "bzr selftest"
> tests the bazaar installation, including plugins.

OK, fine.

> > I was certainly wanting a setup file at some stage. Would also want the
> > pypi metadata too one day.
>
> If I've understood correctly the documentation, the windows installer
> should be available simply from the distutils, as well as the rpm
> packages. I believe debian has some facility to easily generate packages
> from it. pypi should be easy as well.

I'm going to ask Barry to take a look at this as well. While Barry hasn't
been active in this project so far, he has expressed interest in the past, and
knows much more about distutils than I do, and may well be able to suggest a
change or two.

  reviewer barry

Also, this is 0.1 not 0.2 :-)

Will we still need the path hack in the plugin? I think not.

Thanks again

Tim