Code review comment for lp:~madjar/wikkid/plugin

Revision history for this message
Georges Dubus (madjar) wrote :

> OK, I'm not familiar with distutils.
I wasn't until I read the documentation, so I may be wrong on some points

> What is the Manifest file for?
It's a list of the files that should be included in the source distribution (when running install.py sdist) and that are not already included as python modules.

> Also if it is going to attempt to install the file 'run.py' into
> /usr/local/bin, we should rename it.
Yes, obviously. Any suggestion for the name ? Would "wikkid" be good ?

> Do you see any point in distributing the test directories? Is it normal to do
> so?
running "find /usr/lib/python2.6/site-packages -name *test*" should convince you that's the usual thing to do. That's useful when, for example, the development version works, but stop working when you install it. The test will help you in that case. Also, the command "bzr selftest" tests the bazaar installation, including plugins.

> I was certainly wanting a setup file at some stage. Would also want the pypi
> metadata too one day.
If I've understood correctly the documentation, the windows installer should be available simply from the distutils, as well as the rpm packages. I believe debian has some facility to easily generate packages from it. pypi should be easy as well.

« Back to merge proposal