Code review comment for lp:~madjar/wikkid/plugin

Revision history for this message
Georges Dubus (madjar) wrote :

The main advantage of the plugin being included in the main codebase is that
anyone can get it with just a "bzr branch lp:wikkid" in the right place.

The main drawback is that it's base on what may be considered as a hack,
namely the "sys.path.append(os.path.dirname(__file__))" which tend not to work
perfectly in every situation (fails when called from ~/.bazaar/plugins, just
like loggerhead).

Separating the plugin and the main code makes it possible to write a much more
clean plugin, but would require the user to install wikkid before using the
plugin.

To sum up : the integrated plugin makes it easier to use, but may be kind of
hacky. Maybe we should seek advice from the loggerhead guys, who must have had
the same reflexion.

« Back to merge proposal