Code review comment for lp:~maddump/mg5amcnlo/madspin_decay

Revision history for this message
Valentin Hirschi (valentin-hirschi) wrote :

On Thu, May 10, 2018 at 8:05 PM, Olivier Mattelaer <
<email address hidden>> wrote:

> Review: Approve
>
> Hi,
>
> I have done a self review of that code and added one acceptance test to
> ensure that the hepmc mode will still work in the future (this also
> provides some basic test for the hepmc parser).
>
>
> >From your comment Valentin, I assume that I can merge that as soon as the
> maddump author have an interface working within their plugin.
>

Most definitely. Great addon!

> Cheers,
>
> Olivier
> --
> https://code.launchpad.net/~maddump/mg5amcnlo/madspin_decay/+merge/345137
> You are requested to review the proposed merge of
> lp:~maddump/mg5amcnlo/madspin_decay into lp:~mg5core2/mg5amcnlo/2.6.3.
>

--
Valentin

« Back to merge proposal