Code review comment for lp:~maddm/maddm/no_numpy_scipy

Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote :

Hi,

Thanks for the review:

1) Done.

2) I add a warning and a question asking if he wants to generate the diagram anyway (with default to stop)

3) Ok a warning will be displayed but this is not possible in 2.6.2 and will need to wait 2.6.3 but the code is ready for 2.6.3 already.

Thanks,

Olivier

If nobody object, I will release this code this afternoon.

review: Approve

« Back to merge proposal