Code review comment for lp:~maddm/maddm/no_numpy_scipy

mail from federico:

Hi Olivier,

I dowloaded the branch and replaced it inside the PLUGIN directory, so I don’t know how to test what is the behaviour when you try to install maddm without it numpy,scipy.
But it works i.e. I can run maddm without numpy and scipy. Here my comments:

1) If I look at your modified script I read:

"PPC4DMID module requires scipy to be working. Please install those python module. (they are not present)")

but it should be something like:

“Fermi-LAT limit calculation for indirect detection requires numpy and scipy. Please install the missing modules…)

I.e. it is not related to PPPC but in general to Fermi limits.

2) If I don’t have numpy and scipy, why does it compute the diagrams for indirect detection if ask for "add indirect_detection” ?
If the indirect detection module must be switched off, should the whole module be disabled?
I think a warning message should appear when the user tries to add the indirect detection calculation, and then maddm should not calculate anything.

3)
Then I noticed that when I try to switch on the indirect detection, it does not happen of course as we want, but maddm does not print anything on screen,
i.e. if I keen on typing 3 to select the option for indirect detection, on the screen nothing happens.
It should warn that “Indirect detection not available since numpy and scipy are missing…”