Merge lp:~maddevelopers/mg5amcnlo/version_1_2_3 into lp:~madteam/mg5amcnlo/trunk
- version_1_2_3
- Merge into trunk
Proposed by
Johan Alwall
Status: | Merged |
---|---|
Merged at revision: | 137 |
Proposed branch: | lp:~maddevelopers/mg5amcnlo/version_1_2_3 |
Merge into: | lp:~madteam/mg5amcnlo/trunk |
Diff against target: |
221 lines (+52/-22) 7 files modified
Template/Cards/run_card.dat (+5/-0) Template/Cards/run_card_default.dat (+10/-0) Template/SubProcesses/cluster.f (+15/-2) Template/SubProcesses/reweight.f (+4/-2) UpdateNotes.txt (+8/-3) madgraph/VERSION (+2/-2) madgraph/interface/launch_ext_program.py (+8/-13) |
To merge this branch: | bzr merge lp:~maddevelopers/mg5amcnlo/version_1_2_3 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Mattelaer | Approve | ||
Review via email:
|
Commit message
Description of the change
- Fixed long-standing problem that Bogdan pointed out with mixed QED/QCD orders.
- Some fixes to run_card and launch command.
To post a comment you must log in.
Revision history for this message
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Johan Alwall (johan-alwall) wrote : | # |
Hello Olivier,
Sorry, I thought it was obvious. With static variables, if you run
launch several times with running pythia (and pgs), the pythia_card
(and pgs_card) are added on but never removed, so you get multiple
questions if you want to edit the pythia_card.dat.
Johan
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'Template/Cards/run_card.dat' | |||
2 | --- Template/Cards/run_card.dat 2011-04-19 00:55:55 +0000 | |||
3 | +++ Template/Cards/run_card.dat 2011-05-10 22:47:53 +0000 | |||
4 | @@ -157,6 +157,11 @@ | |||
5 | 157 | 0 = mmnl ! min invariant mass for all letpons (l+- and vl) | 157 | 0 = mmnl ! min invariant mass for all letpons (l+- and vl) |
6 | 158 | 1d5 = mmnlmax ! max invariant mass for all letpons (l+- and vl) | 158 | 1d5 = mmnlmax ! max invariant mass for all letpons (l+- and vl) |
7 | 159 | #********************************************************************* | 159 | #********************************************************************* |
8 | 160 | # Minimum and maximum pt for 4-momenta sum of leptons * | ||
9 | 161 | #********************************************************************* | ||
10 | 162 | 0 = ptllmin ! Minimum pt for 4-momenta sum of leptons(l and vl) | ||
11 | 163 | 1d5 = ptllmax ! Maximum pt for 4-momenta sum of leptons(l and vl) | ||
12 | 164 | #********************************************************************* | ||
13 | 160 | # Inclusive cuts * | 165 | # Inclusive cuts * |
14 | 161 | #********************************************************************* | 166 | #********************************************************************* |
15 | 162 | 0 = xptj ! minimum pt for at least one jet | 167 | 0 = xptj ! minimum pt for at least one jet |
16 | 163 | 168 | ||
17 | === modified file 'Template/Cards/run_card_default.dat' | |||
18 | --- Template/Cards/run_card_default.dat 2011-03-02 18:01:07 +0000 | |||
19 | +++ Template/Cards/run_card_default.dat 2011-05-10 22:47:53 +0000 | |||
20 | @@ -70,6 +70,11 @@ | |||
21 | 70 | # BW cutoff (M+/-bwcutoff*Gamma) | 70 | # BW cutoff (M+/-bwcutoff*Gamma) |
22 | 71 | #********************************** | 71 | #********************************** |
23 | 72 | 15 = bwcutoff | 72 | 15 = bwcutoff |
24 | 73 | #********************************************************** | ||
25 | 74 | # Apply pt/E/eta/dr/mij cuts on decay products or not | ||
26 | 75 | # (note that etmiss/ptll/ptheavy/sorted cuts always apply) | ||
27 | 76 | #********************************************************** | ||
28 | 77 | F = cut_decays | ||
29 | 73 | #******************* | 78 | #******************* |
30 | 74 | # Standard Cuts | 79 | # Standard Cuts |
31 | 75 | #******************* | 80 | #******************* |
32 | @@ -152,6 +157,11 @@ | |||
33 | 152 | 0 = mmnl ! min invariant mass for all letpons (l+- and vl) | 157 | 0 = mmnl ! min invariant mass for all letpons (l+- and vl) |
34 | 153 | 1d5 = mmnlmax ! max invariant mass for all letpons (l+- and vl) | 158 | 1d5 = mmnlmax ! max invariant mass for all letpons (l+- and vl) |
35 | 154 | #********************************************************************* | 159 | #********************************************************************* |
36 | 160 | # Minimum and maximum pt for 4-momenta sum of leptons * | ||
37 | 161 | #********************************************************************* | ||
38 | 162 | 0 = ptllmin ! Minimum pt for 4-momenta sum of leptons(l and vl) | ||
39 | 163 | 1d5 = ptllmax ! Maximum pt for 4-momenta sum of leptons(l and vl) | ||
40 | 164 | #********************************************************************* | ||
41 | 155 | # Inclusive cuts * | 165 | # Inclusive cuts * |
42 | 156 | #********************************************************************* | 166 | #********************************************************************* |
43 | 157 | 0 = xptj ! minimum pt for at least one jet | 167 | 0 = xptj ! minimum pt for at least one jet |
44 | 158 | 168 | ||
45 | === modified file 'Template/SubProcesses/cluster.f' | |||
46 | --- Template/SubProcesses/cluster.f 2011-04-14 02:31:58 +0000 | |||
47 | +++ Template/SubProcesses/cluster.f 2011-05-10 22:47:53 +0000 | |||
48 | @@ -498,6 +498,7 @@ | |||
49 | 498 | include 'nexternal.inc' | 498 | include 'nexternal.inc' |
50 | 499 | include 'cluster.inc' | 499 | include 'cluster.inc' |
51 | 500 | include 'message.inc' | 500 | include 'message.inc' |
52 | 501 | include 'maxconfigs.inc' | ||
53 | 501 | real*8 p(0:3,nexternal), pcmsp(0:3), p1(0:3) | 502 | real*8 p(0:3,nexternal), pcmsp(0:3), p1(0:3) |
54 | 502 | real*8 pi(0:3), nr(0:3), pz(0:3) | 503 | real*8 pi(0:3), nr(0:3), pz(0:3) |
55 | 503 | integer i, j, k, n, idi, idj, idij, icgs(0:n_max_cg) | 504 | integer i, j, k, n, idi, idj, idij, icgs(0:n_max_cg) |
56 | @@ -505,6 +506,9 @@ | |||
57 | 505 | double precision nn2,ct,st | 506 | double precision nn2,ct,st |
58 | 506 | double precision minpt2ij,pt2ij(n_max_cl),zij(n_max_cl) | 507 | double precision minpt2ij,pt2ij(n_max_cl),zij(n_max_cl) |
59 | 507 | 508 | ||
60 | 509 | integer mapconfig(0:lmaxconfigs), this_config | ||
61 | 510 | common/to_mconfigs/mapconfig, this_config | ||
62 | 511 | |||
63 | 508 | integer nbw,ibwlist(nexternal) | 512 | integer nbw,ibwlist(nexternal) |
64 | 509 | logical isbw(n_max_cl) | 513 | logical isbw(n_max_cl) |
65 | 510 | data isbw/n_max_cl*.false./ | 514 | data isbw/n_max_cl*.false./ |
66 | @@ -632,13 +636,13 @@ | |||
67 | 632 | write(*,*)'winner ',n,': ',idacl(n,1),'&',idacl(n,2), | 636 | write(*,*)'winner ',n,': ',idacl(n,1),'&',idacl(n,2), |
68 | 633 | & ' -> ',minpt2ij,', z = ',zcl(n) | 637 | & ' -> ',minpt2ij,', z = ',zcl(n) |
69 | 634 | endif | 638 | endif |
71 | 635 | c Reset igscl with new mother | 639 | c Reset igraphs with new mother |
72 | 636 | if (.not.findmt(imocl(n),igraphs,nbw,ibwlist)) then | 640 | if (.not.findmt(imocl(n),igraphs,nbw,ibwlist)) then |
73 | 637 | write(*,*) 'cluster.f: Error. Invalid combination.' | 641 | write(*,*) 'cluster.f: Error. Invalid combination.' |
74 | 638 | return | 642 | return |
75 | 639 | endif | 643 | endif |
76 | 640 | if (btest(mlevel,4)) then | 644 | if (btest(mlevel,4)) then |
78 | 641 | write(*,*)'diagrams: ',(igraphs(k),k=1,igraphs(0)) | 645 | write(*,*)'graphs: ',(igraphs(k),k=1,igraphs(0)) |
79 | 642 | endif | 646 | endif |
80 | 643 | if (iwin.lt.3) then | 647 | if (iwin.lt.3) then |
81 | 644 | c is clustering | 648 | c is clustering |
82 | @@ -739,6 +743,15 @@ | |||
83 | 739 | write(*,*) 'Last vertex is ',imap(1,2),imap(2,2),imap(3,2) | 743 | write(*,*) 'Last vertex is ',imap(1,2),imap(2,2),imap(3,2) |
84 | 740 | write(*,*) ' -> ',pt2ijcl(n+1),sqrt(pt2ijcl(n+1)) | 744 | write(*,*) ' -> ',pt2ijcl(n+1),sqrt(pt2ijcl(n+1)) |
85 | 741 | endif | 745 | endif |
86 | 746 | c If present channel among graphs, use only this channel | ||
87 | 747 | c This is important when we have mixed QED-QCD | ||
88 | 748 | do i=1,igraphs(0) | ||
89 | 749 | if (igraphs(i).eq.this_config) then | ||
90 | 750 | igraphs(0)=1 | ||
91 | 751 | igraphs(1)=this_config | ||
92 | 752 | exit | ||
93 | 753 | endif | ||
94 | 754 | enddo | ||
95 | 742 | c if(pt2ijcl(n).gt. pt2ijcl(n+1))then | 755 | c if(pt2ijcl(n).gt. pt2ijcl(n+1))then |
96 | 743 | c pt2ijcl(n+1)=pt2ijcl(n) | 756 | c pt2ijcl(n+1)=pt2ijcl(n) |
97 | 744 | c if (btest(mlevel,3)) then | 757 | c if (btest(mlevel,3)) then |
98 | 745 | 758 | ||
99 | === modified file 'Template/SubProcesses/reweight.f' | |||
100 | --- Template/SubProcesses/reweight.f 2011-04-21 15:56:29 +0000 | |||
101 | +++ Template/SubProcesses/reweight.f 2011-05-10 22:47:53 +0000 | |||
102 | @@ -412,8 +412,10 @@ | |||
103 | 412 | if (btest(mlevel,1)) then | 412 | if (btest(mlevel,1)) then |
104 | 413 | write(*,*)'setclscales: identified tree {' | 413 | write(*,*)'setclscales: identified tree {' |
105 | 414 | do i=1,nexternal-2 | 414 | do i=1,nexternal-2 |
108 | 415 | write(*,*)' ',i,': ',idacl(i,1),'&',idacl(i,2), | 415 | write(*,*)' ',i,': ',idacl(i,1),'(',ipdgcl(idacl(i,1),igraphs(1)),')', |
109 | 416 | & ' -> ',imocl(i),', ptij = ',dsqrt(pt2ijcl(i)) | 416 | $ '&',idacl(i,2),'(',ipdgcl(idacl(i,2),igraphs(1)),')', |
110 | 417 | $ ' -> ',imocl(i),', ptij = ',dsqrt(pt2ijcl(i)), | ||
111 | 418 | $ '(',ipdgcl(imocl(i),igraphs(1)),')' | ||
112 | 417 | enddo | 419 | enddo |
113 | 418 | write(*,*)' graphs (',igraphs(0),'):',(igraphs(i),i=1,igraphs(0)) | 420 | write(*,*)' graphs (',igraphs(0),'):',(igraphs(i),i=1,igraphs(0)) |
114 | 419 | write(*,*)'}' | 421 | write(*,*)'}' |
115 | 420 | 422 | ||
116 | === modified file 'UpdateNotes.txt' | |||
117 | --- UpdateNotes.txt 2011-05-08 22:57:35 +0000 | |||
118 | +++ UpdateNotes.txt 2011-05-10 22:47:53 +0000 | |||
119 | @@ -1,8 +1,13 @@ | |||
120 | 1 | Update notes for MadGraph 5 (in reverse time order) | 1 | Update notes for MadGraph 5 (in reverse time order) |
121 | 2 | 2 | ||
125 | 3 | 1.2.2 (09/05/11) OM: fix ALOHA symmetries creating not gauge invariant result for scalar octet | 3 | 1.2.3 (11/05/11): JA: Fixed problem with scale choice in processes with mixed |
126 | 4 | 4 | QED/QCD orders, e.g. p p > t t~ QED=2 | |
127 | 5 | 1.2.1 (08/05/11) OM: reduce the quantity of RAM use by matrix.f | 5 | JA: Added the ptllmin/max options in the default run_card.dat |
128 | 6 | |||
129 | 7 | 1.2.2 (09/05/11): OM: fix ALOHA symmetries creating not gauge invariant result | ||
130 | 8 | for scalar octet | ||
131 | 9 | |||
132 | 10 | 1.2.1 (08/05/11): OM: reduce the quantity of RAM use by matrix.f | ||
133 | 6 | OM: support speed of psyco if this python module is installed | 11 | OM: support speed of psyco if this python module is installed |
134 | 7 | OM: fix a minor bug in the model parsing | 12 | OM: fix a minor bug in the model parsing |
135 | 8 | OM: add the check of valid model.pkl also for v4 model | 13 | OM: add the check of valid model.pkl also for v4 model |
136 | 9 | 14 | ||
137 | === modified file 'madgraph/VERSION' | |||
138 | --- madgraph/VERSION 2011-05-08 22:57:35 +0000 | |||
139 | +++ madgraph/VERSION 2011-05-10 22:47:53 +0000 | |||
140 | @@ -1,2 +1,2 @@ | |||
143 | 1 | version = 1.2.2 | 1 | version = 1.2.3 |
144 | 2 | date = 2011-05-08 | 2 | date = 2011-05-11 |
145 | 3 | 3 | ||
146 | === modified file 'madgraph/interface/launch_ext_program.py' | |||
147 | --- madgraph/interface/launch_ext_program.py 2011-05-03 19:17:59 +0000 | |||
148 | +++ madgraph/interface/launch_ext_program.py 2011-05-10 22:47:53 +0000 | |||
149 | @@ -36,7 +36,6 @@ | |||
150 | 36 | program_dir = '' | 36 | program_dir = '' |
151 | 37 | executable = '' # path from program_dir | 37 | executable = '' # path from program_dir |
152 | 38 | 38 | ||
153 | 39 | cards = [] # files can be modified (path from self.card_dir) | ||
154 | 40 | force = False | 39 | force = False |
155 | 41 | 40 | ||
156 | 42 | def __init__(self, running_dir, card_dir='', timeout=None, | 41 | def __init__(self, running_dir, card_dir='', timeout=None, |
157 | @@ -51,6 +50,7 @@ | |||
158 | 51 | for key,value in options.items(): | 50 | for key,value in options.items(): |
159 | 52 | setattr(self, key, value) | 51 | setattr(self, key, value) |
160 | 53 | 52 | ||
161 | 53 | self.cards = [] # files can be modified (path from self.card_dir) | ||
162 | 54 | 54 | ||
163 | 55 | def run(self): | 55 | def run(self): |
164 | 56 | """ execute the main code """ | 56 | """ execute the main code """ |
165 | @@ -147,12 +147,12 @@ | |||
166 | 147 | class SALauncher(ExtLauncher): | 147 | class SALauncher(ExtLauncher): |
167 | 148 | """ A class to launch a simple Standalone test """ | 148 | """ A class to launch a simple Standalone test """ |
168 | 149 | 149 | ||
169 | 150 | cards = ['param_card.dat'] | ||
170 | 151 | |||
171 | 152 | def __init__(self, running_dir, timeout, **options): | 150 | def __init__(self, running_dir, timeout, **options): |
172 | 153 | """ initialize the StandAlone Version""" | 151 | """ initialize the StandAlone Version""" |
173 | 154 | 152 | ||
174 | 155 | ExtLauncher.__init__(self, running_dir, './Cards', timeout, **options) | 153 | ExtLauncher.__init__(self, running_dir, './Cards', timeout, **options) |
175 | 154 | self.cards = ['param_card.dat'] | ||
176 | 155 | |||
177 | 156 | 156 | ||
178 | 157 | def launch_program(self): | 157 | def launch_program(self): |
179 | 158 | """launch the main program""" | 158 | """launch the main program""" |
180 | @@ -170,8 +170,6 @@ | |||
181 | 170 | class MELauncher(ExtLauncher): | 170 | class MELauncher(ExtLauncher): |
182 | 171 | """A class to launch MadEvent run""" | 171 | """A class to launch MadEvent run""" |
183 | 172 | 172 | ||
184 | 173 | cards = ['param_card.dat', 'run_card.dat'] | ||
185 | 174 | |||
186 | 175 | def __init__(self, running_dir, timeout, unit='pb', **option): | 173 | def __init__(self, running_dir, timeout, unit='pb', **option): |
187 | 176 | """ initialize the StandAlone Version""" | 174 | """ initialize the StandAlone Version""" |
188 | 177 | 175 | ||
189 | @@ -182,6 +180,7 @@ | |||
190 | 182 | assert hasattr(self, 'name') | 180 | assert hasattr(self, 'name') |
191 | 183 | self.unit = unit | 181 | self.unit = unit |
192 | 184 | 182 | ||
193 | 183 | self.cards = ['param_card.dat', 'run_card.dat'] | ||
194 | 185 | # Check for pythia-pgs directory | 184 | # Check for pythia-pgs directory |
195 | 186 | if os.path.isdir(os.path.join(MG5DIR,'pythia-pgs')): | 185 | if os.path.isdir(os.path.join(MG5DIR,'pythia-pgs')): |
196 | 187 | self.pythia = os.path.join(MG5DIR,'pythia-pgs') | 186 | self.pythia = os.path.join(MG5DIR,'pythia-pgs') |
197 | @@ -305,20 +304,16 @@ | |||
198 | 305 | class Pythia8Launcher(ExtLauncher): | 304 | class Pythia8Launcher(ExtLauncher): |
199 | 306 | """A class to launch Pythia8 run""" | 305 | """A class to launch Pythia8 run""" |
200 | 307 | 306 | ||
201 | 308 | cards = [] | ||
202 | 309 | |||
203 | 310 | def __init__(self, running_dir, timeout, **option): | 307 | def __init__(self, running_dir, timeout, **option): |
204 | 311 | """ initialize launching Pythia 8""" | 308 | """ initialize launching Pythia 8""" |
205 | 312 | 309 | ||
206 | 313 | running_dir = os.path.join(running_dir, 'examples') | 310 | running_dir = os.path.join(running_dir, 'examples') |
207 | 314 | ExtLauncher.__init__(self, running_dir, '.', timeout, **option) | 311 | ExtLauncher.__init__(self, running_dir, '.', timeout, **option) |
208 | 315 | |||
209 | 316 | |||
210 | 317 | def prepare_run(self): | ||
211 | 318 | """ ask for pythia-pgs/delphes run """ | ||
212 | 319 | |||
213 | 320 | self.cards = [] | 312 | self.cards = [] |
215 | 321 | 313 | ||
216 | 314 | def prepare_run(self): | ||
217 | 315 | """ ask for pythia-pgs/delphes run """ | ||
218 | 316 | |||
219 | 322 | # Find all main_model_process.cc files | 317 | # Find all main_model_process.cc files |
220 | 323 | date_file_list = [] | 318 | date_file_list = [] |
221 | 324 | for file in glob.glob(os.path.join(self.running_dir,'main_*_*.cc')): | 319 | for file in glob.glob(os.path.join(self.running_dir,'main_*_*.cc')): |
Could you comment on your modification on the launch command.
I don't see the point of those modifications, is there a reason for this change, or this is only for the beauty of it?