Code review comment for lp:~maddevelopers/mg5amcnlo/plugin_plus_py8

Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote :

43) some acceptance test are failing (related to self.proc_defs @NLO)

44) The question for madanalysis should be changed for the display to the user.
44.1)I would propose:

The following switches determine which programs are run:
 1 Choose the shower/hadronization program: shower = OFF
 2 Choose the detector simulation program: detector = OFF
 3 Choose which the plotting/analysis program: analysis = OFF
 3 Decay particles with the MadSpin module: madspin = OFF
 4 Add weights to the events based on changing model parameters: reweight = OFF
  Either type the switch number (1 to 5) to change its setting,
  Set any switch explicitly (e.g. type 'madspin=ON' at the prompt)
  Type 'help' for the list of all valid option
  Type '0', 'auto', 'done' or just press enter when you are done.

Such that
a) we can add other package easily. (like the fortran analysis present in MC@NLO, or interface to Falstlim/Rivet/...)
b) Such that we can choose to use either MA4 or MA5

44.2) Also, contrary to the other options, the default should be to have the plotting routine activated when installed. (at least for the parton level)

44.3) I would propose to have only MA5 as option (equivalent to parton+hadron if shower is run)
      (potentially have a way in the madanalysis_hadron card to specify that you want to bypass it if needed)

44.4) Neither madanalysis5_parton/hadron have an help message working with this question.

« Back to merge proposal