Let move forward on the point 3 of the review:
reviewing the change in cuts.f (not done before to the a windows -> linux conversion on end of line)
3.1) The following is at least weird
C COUNT NUMBER OF MASSLESS OUTGOING PARTICLES, SINCE WE DO NOT WANT
C TO APPLY A CUT FOR JUST A SINGLE MASSIVE PARTICLE IN THE FINAL STATE.
NMASSLESS = 0
DO I=NINCOMING+1,NEXTERNAL if(is_pdg_for_merging_cut(i) .and. .not. from_decay(I) .and.
& DSQRT(DOT( P(0,I), P(0,I))) .LT. 5D0) THEN NMASSLESS = NMASSLESS + 1
ENDIF
ENDDO
this seems to count in 4F and 5F the b as massles (which sounds bad to me)
should not we use maxjetflavor for this?
3.2) some comment as 3.1 but for ptlund.
C PROCESS WITH EXACTLY TWO MASSLESS OUTGOING PARTICLES IS SPECIAL
C BECAUSE AN ENERGY-SHARING VARIABLE LIKE "Z" DOES NOT MAKE SENSE.
C IN THIS CASE, ONLY APPLY MINIMAL pT W.R.T BEAM CUT.
C THIS CUT WILL ONLY APPLY TO THE TWO-MASSLESS PARTICLE STATE.
NMASSLESS = 0
DO I=NINCOMING+1,NEXTERNAL if(is_pdg_for_merging_cut(i) .and. .not. from_decay(I) .and.
& DSQRT(DOT( P(0,I), P(0,I))) .LT. 5D0) THEN NMASSLESS = NMASSLESS + 1
ENDIF
ENDDO
So I marked 3 done in the wiki and add two line in the wiki for those two (identical) point
Otherwise here is two additional point
40) the edition of the card does not work
41) the auto-completion of install MadAnalysis does not work after the first option.
(try to auto-complete install MadAnalysis5 --no_root_in_MA5)
42) the instalation of MA5 fails without the option "--no_root_in_MA5 --no_MA5_further_install"
would be nice to either automatically switch to those options or at least suggest them to the user when it fails
Let move forward on the point 3 of the review:
reviewing the change in cuts.f (not done before to the a windows -> linux conversion on end of line)
3.1) The following is at least weird 1,NEXTERNAL
if(is_ pdg_for_ merging_ cut(i) .and. .not. from_decay(I) .and.
NMASSLESS = NMASSLESS + 1
C COUNT NUMBER OF MASSLESS OUTGOING PARTICLES, SINCE WE DO NOT WANT
C TO APPLY A CUT FOR JUST A SINGLE MASSIVE PARTICLE IN THE FINAL STATE.
NMASSLESS = 0
DO I=NINCOMING+
& DSQRT(DOT( P(0,I), P(0,I))) .LT. 5D0) THEN
ENDIF
ENDDO
this seems to count in 4F and 5F the b as massles (which sounds bad to me)
should not we use maxjetflavor for this?
3.2) some comment as 3.1 but for ptlund. 1,NEXTERNAL
if(is_ pdg_for_ merging_ cut(i) .and. .not. from_decay(I) .and.
NMASSLESS = NMASSLESS + 1
C PROCESS WITH EXACTLY TWO MASSLESS OUTGOING PARTICLES IS SPECIAL
C BECAUSE AN ENERGY-SHARING VARIABLE LIKE "Z" DOES NOT MAKE SENSE.
C IN THIS CASE, ONLY APPLY MINIMAL pT W.R.T BEAM CUT.
C THIS CUT WILL ONLY APPLY TO THE TWO-MASSLESS PARTICLE STATE.
NMASSLESS = 0
DO I=NINCOMING+
& DSQRT(DOT( P(0,I), P(0,I))) .LT. 5D0) THEN
ENDIF
ENDDO
So I marked 3 done in the wiki and add two line in the wiki for those two (identical) point
Otherwise here is two additional point
40) the edition of the card does not work
41) the auto-completion of install MadAnalysis does not work after the first option.
(try to auto-complete install MadAnalysis5 --no_root_in_MA5)
42) the instalation of MA5 fails without the option "--no_root_in_MA5 --no_MA5_ further_ install"
would be nice to either automatically switch to those options or at least suggest them to the user when it fails