Code review comment for lp:~maddevelopers/mg5amcnlo/plugin_mode

Revision history for this message
Sébastien Wertz (sebastien-wertz) wrote :

> I tried the examples and it seems to works fine. I would have to develop my
> own real non-trivial plugin to unravel potential problems, so I only have the
> following superficial remarks here:

> 1) Out of curiosity, why was 'using namespace std' not OK for the C++ output?

Hi Valentin,

If you want to check a "non-trivial" plugin, you can always try out the C++ one we've written for the MEM: https://github.com/MoMEMta/MoMEMta-MaGMEE. You won't be able to compile the resulting code without installing our framework, but the plugin output works nonetheless.

Regarding the 'using namespace' statements in C++, it's a problem if they are used in header files: any code directly or indirectly including those headers will get polluted by the namespace, which can cause collisions. Those statements should always only be included in non-header files.

Cheers,
Sébastien

« Back to merge proposal