Code review comment for lp:~maddevelopers/mg5amcnlo/nlo_reweighting

Hi Valentin,

This has nothing to do with RunWeb. I implemented a hidden method to run one single command bypassing all interactions with RunWeb.

Looks like the error catching was using a undefined error in amcatnlo_runinterface (while it was define in the madevent one).
and that make the code to fail to crash correctly.

I fix it but you will still face the real crash… (that I have no idea what it is in your case)
I doubt that this is linked to lhapdf since you also have it for kamikaze…

Cheers,

Olivier

> On Feb 28, 2016, at 03:29, Valentin Hirschi <email address hidden> wrote:
>
> Hi Olivier,
>
> So I tried again the very default run, that is
>
> generate p p > e+ ve [NLO]
> output
> launch
>
> Then I turned off the shower and turned on the reweighting (without turning on LHAPDF).
> As expected the code turned keep_rwgt_info to True automatically, which is nice, i.e.
>
> NLO reweighting is on ON. Automatically set keep_rwgt_info to True
>
> but then it crashed, probably because it needs lhadpf?
> This time around and thanks to the sandboxing I suggested and that you worked hard to implement, the crash is nice:
>
> [...]
> DEBUG: Traceback (most recent call last):
> DEBUG: File "/Users/valentin/Documents/Work/MG5/nlo_reweighting/PROCNLO_loop_sm_18/bin/internal/amcatnlo_run_interface.py", line 4816, in <module>
> DEBUG: except MadEventAlreadyRunning, error:
> DEBUG: NameError: name 'MadEventAlreadyRunning' is not defined
> ERROR: Reweighting failed
> decay_events -from_cards
>
> Then I went on and turned LHAPDF but got the same error as above. So it looks like you have an issue with the fact that you now run the reweight separately but there is of course still the 'RunWeb' tagger file present, so it crashes. How come you didn't run into the same issue?
>
> Even with the kamikaze reweighting (mode LO), the issue above occurs.
> So I need it to be fixed in order to continue the review.
>
> Cheers
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/nlo_reweighting/+merge/283769
> Your team MadDevelopers is subscribed to branch lp:~maddevelopers/mg5amcnlo/2.3.4.