Code review comment for lp:~maddevelopers/mg5amcnlo/nlo_reweighting

Hi,

> IndexError: list index out of range (line 1120 in common_run_interface.py).

Did you have the latest version of the code?
In my computer this lines are:

                if any(t in line for t in ['INFO:', 'WARNING:', 'CRITICAL:', 'ERROR:', 'root:']) and \
                   not ‘***********’ in line: #<<<<<<<<<<<<<line 1120
                        print line[:-1].replace(‘INFO’, 'REWEIGTH')
                elif __debug__ and line:
                    logger.debug(line[:-1])

This is just impossible that line 1120 (or 1119) raise an IndexError.
Line 1121: can not raise an index error (potentially a TypeError but not an IndexError.

So my best guess is that we do not have the same version. I’m at version 367

> B.t.w., what's the difference between NLO_basic and NLO_VT ? The wiki-page is not very enlightening on this subject.

They differ on how they reweight some of the contribution
- the born
- the approximate virtual
- the virtual
They have the same treatment for the various counter-term.

NLO_basic reweighs
- the born by the ratio of the borns
- the approximate virtual by the ratio of the borns
- the virtual by the ratio of the virtual

NLO_VT reweighs those three contributions by the ratio of the sum of the Born and the virtual (B+V).

The interest of those two is that this can enlighten the sensitivity to the virt-trick if they differ from each other.

Cheers,

Olivier

> On Feb 25, 2016, at 08:56, Rikkert Frederix <email address hidden> wrote:
>
> Hi Olivier,
>
> I wanted to go back to testing this branch, but still I can't get it working at NLO. Even with the default setup (only turning the REWEIGHT=ON), the code crashes when starting the reweighting with a IndexError: list index out of range (line 1120 in common_run_interface.py).
>
> B.t.w., what's the difference between NLO_basic and NLO_VT ? The wiki-page is not very enlightening on this subject.
>
> Cheers,
> Rik
>
>
>
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/nlo_reweighting/+merge/283769
> Your team MadDevelopers is subscribed to branch lp:~maddevelopers/mg5amcnlo/2.3.4.