Code review comment for lp:~maddevelopers/mg5amcnlo/nlo_reweighting

Revision history for this message
Rikkert Frederix (frederix) wrote :

Hi Olivier,

I really think you should do some more testing before asking for a review. Now the code runs, but the reweighted cross sections is orders of magnitude away from the correct value.

generate p p > e+ ve [QCD] ; output
launch --> "reweight ON' and 'keep_rwgt_info --> True'

(It gives the warning that the cards are identical, but it runs anyway due to DEBUG mode).

gives that the reweighted cross section is ~4.3 pb, while the original is ~1.0*10^4 pb.

Cheers,
Rik

review: Needs Fixing

« Back to merge proposal