Code review comment for lp:~maddevelopers/mg5amcnlo/nlo_reweighting

Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote :

Hi Rik,

Yes this mode need lhapdf.
I do not want to play with internal pdf.

I will add this in the documentation and add the code to check if lhapdf is present or not before proposing to the user
to use the module.

Cheers and thanks,

Olivier

> On Feb 3, 2016, at 13:49, Rikkert Frederix <email address hidden> wrote:
>
> Review: Needs Fixing
>
> Hi Olivier,
>
> It doesn't work. f2py tries to link LHAPDF, even though I didn't specify the code to use LHAPDF and I get a crash that it doesn't fine the -lLHAPDF library.
>
> cheers,
> Rik
>
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/nlo_reweighting/+merge/283769
> Your team MadDevelopers is subscribed to branch lp:~maddevelopers/mg5amcnlo/2.3.4.

« Back to merge proposal