Code review comment for lp:~maddevelopers/mg5amcnlo/fix_majorana_flipping

Revision history for this message
Johan Alwall (johan-alwall) wrote :

Hello again,

> > I would strongly suggest to split majorana_conjugates
> > in two separate functions. One for the wavefunctions and one for the
> > amplitudes.
> > the number of if in this case checking in which case we are (and some of
> them
> > quite implicit)
> > makes the code un-readable.

I have taken care of this, I hope you like my new implementation better. It should be considerably more intuitive and readable.

> > We can:
> > 1) store the data (forbids the static method but fine if you split the
> routine
> > in two as suggested above) such that the data is compute only once.

Done.

Thanks!
Johan

« Back to merge proposal