Code review comment for lp:~maddevelopers/mg5amcnlo/3.0.2-alpha0

Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote :

This is very good and basically ready to be merged.

Some minor point.
1) !z! works ... should not be this forbidden?
2) can we use tagged photon with QCD correction only?
-- In the commit I did, I have added unittest that crash related to the above command, you can remove those test if those are fine--
3) 2!a! was making the code to crash but !2a! was working fine. I have updated the parser to support both.
4) I have spotted a typo in banner.py (see the comment within the diff for that)
5) I have loose track of all the change in cuts.f but did not spot anything obviously wrong. If you are not confident enough about that part maybe I should go deeper and track that we did not "loose" any previous cut but sounds like it.

Thanks a lot and sorry for being slow on this review

review: Approve

« Back to merge proposal