Code review comment for lp:~maddevelopers/mg5amcnlo/2.6.3_optimizenlomodel
Revision history for this message
| Olivier Mattelaer (olivier-mattelaer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hi,
OK this seems quite stable now.
I'm just a bit worried that the parallel test might not be complete enough to detect issue here.
I think that such changes can be really important for complex model (in term of speed/precision).
But such improvement required complex model but this makes the possibility to not detect the introduction of subtle bugs (which will not be detected via unittest/...).
If you have an idea of parallel test (i.e. model/process) this would be great.
Cheers,
Olivier