Code review comment for lp:~maddevelopers/mg5amcnlo/2.3.4-low-memory

Ciao Olivier,
thanks for the comment
On 29 Feb 2016, at 11:50, Olivier Mattelaer <email address hidden> wrote:

>> Hi Olivier,
>> I have changed the arguments to options, please have a look. I have also
>> removed a chunk of code from fks_base (10 lines starting with #check
>> limitations of FKS) which did not make any sense and was never used.
>
> That's already much nicer. Thanks.
>
> Actually my argument was to avoid to use the full options of MadGraph:
> and therefore have instead of
> self._fks_multi_proc = fks_base.FKSMultiProcess(myprocdef,fks_options)
> the following line:
> self._fks_multi_proc = fks_base.FKSMultiProcess(myprocdef,self.options)
anyway the same options will have to be passed to the MultiProcess Instance, and many of them are not valid.
So sooner or later one has to create a new dictionary…
I will proceed with the merge

Cheers,

Marco
>
> Obviously, this force to have a slightly different behavior for
> ncores_for_proc_gen
> since that one is not part of the self.options dictionary.
> The two advantages: all the configuration options are available and less memory consumption (since you have one less dictionary in memory).
>
> But this is already so much nicer that I'm more than happy with your nice change.
> So this comment was just to clarify my point and not to encourage you to perform any changes.
>
> Thanks,
>
> Olivier
>
> Olivier
>
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.3.4-low-memory/+merge/286337
> Your team MadDevelopers is requested to review the proposed merge of lp:~maddevelopers/mg5amcnlo/2.3.4-low-memory into lp:~maddevelopers/mg5amcnlo/2.3.4.