Code review comment for lp:~maddevelopers/mg5amcnlo/2.3.4-low-memory

Revision history for this message
Valentin Hirschi (valentin-hirschi) wrote :

Hi Marco,

I tested the OLP=GoSam behavior and a couple other things and everything went smooth.

So please just confirm that you checked that there couldn't be any border effect on the modification of the function 'RunCardNLO.create_default_for_process(' from other parts of the code that might use it and also the fact that no deepcopy at all is used in the new low-mem mode.

Anyway, I assume that the above is indeed the case so that I already give my green light.

Great work,

Cheers

review: Approve

« Back to merge proposal