Code review comment for lp:~maddevelopers/mg5amcnlo/2.3.4-low-memory

Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote :

Hi Marco,

I will accept the merge even without the fix associate to this:

>> 3) concerning the ncores options, would not be better to pass to the class the self.options of the interface? Such that we do not have to multiply the optional argument when we to have access to any of the options define in that dictionary (this should have been done for OLP)

But please do like that next time, since it is easier if we have access to the full user options rather that duplicate the information.

Cheers,

Olivier

review: Approve

« Back to merge proposal