Code review comment for lp:~maddevelopers/mg5amcnlo/2.3.4-low-memory

Ciao Rik,
catching ctrl+c should be ok now.
Another thing i have noticed, is that by default all available cores are used… The nb_core option should be used instead for that, i will fix also this issue
Ciao,

Marco
On 18 Feb 2016, at 10:33, marco zaro <email address hidden> wrote:

> Hi Rik
> On 18 Feb 2016, at 09:29, Rikkert Frederix <email address hidden> wrote:
>
>> Review: Needs Fixing
>>
>> Hi Marco,
>>
>> I would rename the option "new_nlo_generation" to something like "low_memory_multicore_nlo_generation" (or something shorter/better).
>>
> I did not think much about the name
>
>> It seems like Ctrl-C doesn't work correctly during the 'output' of the process.
>>
> argh, that was something we have already seen when we used the same multicore threading for compiling…
> I will have a look and let you know…
> Cheers,
>
> Marco
>
>> Cheers,
>> Rik
>>
>> --
>> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.3.4-low-memory/+merge/286337
>> Your team MadDevelopers is requested to review the proposed merge of lp:~maddevelopers/mg5amcnlo/2.3.4-low-memory into lp:~maddevelopers/mg5amcnlo/2.3.4.
>
>
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.3.4-low-memory/+merge/286337
> Your team MadDevelopers is requested to review the proposed merge of lp:~maddevelopers/mg5amcnlo/2.3.4-low-memory into lp:~maddevelopers/mg5amcnlo/2.3.4.