Code review comment for lp:~maddevelopers/mg5amcnlo/2.2.3

Revision history for this message
Rikkert Frederix (frederix) wrote :

Hi Olivier,

> RF: If a NAN is found, the code now skips that PS point and continues.

Due to numerical inaccuracies, very rarely you might get a NAN from the phase-space generation or somewhere else for a single PS point. Before the code added this NAN phase-space points to the result, which meant that all became NANs. Now it simply skips this very rare PS point and continues correctly.

> RF: For fNLO runs the virtuals were included twice in the setting of the
> integration grids.

This is nothing serious: it was only in the setting of the grids, not in the actual results. Moreover, due to the virt-tricks the actual contribution from the virtuals is nearly always negligible anyway.

Cheers,
Rik

« Back to merge proposal