Code review comment for lp:~maddevelopers/mg5amcnlo/2.1.2-lhapdf6

Ciao Olivier,
this crash is there in 2.1.2 as well
it is related to the fact that if you run first with internal pdfs, then a
second time with the lhapdf ones, some files in Source need to be
recompiled in order to have LHAPDF working.
The error

 Unimplemented distribution= lhapdf
 Implemented are:
mrs02nl,mrs02nn,mrs0119,mrs0117,mrs0121,mrs01_j,mrs99_1,mrs99_2,mrs99_3,mrs99_4,mrs99_5,mrs99_6,mrs99_7,mrs99_8,mrs99_9,mrs9910,mrs9911,mrs9912,mrs98z1,mrs98z2,mrs98z3,mrs98z4,mrs98z5,mrs98ht,mrs98l1,mrs98l2,mrs98l3,mrs98l4,mrs98l5,cteq3_m,cteq3_l,cteq3_d,cteq4_m,cteq4_d,cteq4_l,cteq4a1,cteq4a2,cteq4a3,cteq4a4,cteq4a5,cteq4hj,cteq4lq,cteq5_m,cteq5_d,cteq5_l,cteq5hj,cteq5hq,cteq5f3,cteq5f4,cteq5m1,ctq5hq1,cteq5l1,cteq6_m,cteq6_d,cteq6_l,cteq6l1,nn23lo,nn23lo1,nn23nlo,

comes from PDF/pdfwrap.f, which should not be compiled and linked if one is
using lhapdf.

in the NLO Source makefile, there is 'clean4pdf' which removes the existing
libraries

clean4pdf:

        rm -f ../lib/libpdf.a

        rm -f ../lib/libgeneric.a

and it is not there in the LO one.
It is called at every run, when Source is compiled.

This should fix the madevent behaviour.

Cheers,

Marco

Marco Zaro

On Thu, Aug 21, 2014 at 4:17 PM, Olivier Mattelaer <
<email address hidden>> wrote:

>
> For the print statement, it was happening only once (the very first time).
> No idea why...
> I guess that we can forget that proble,
>
> I realize that I forget to put the command that I use for the second bug
> (the critical one).
>
> generate p p > e+ e-
> launch
> set pdlabel lhapdf
> set lhaid 70251
> launch
> set pdlabel cteq6l1
> launch
> set pdlabel lhapdf
>
> actually the command crash as well:
> generate p p > e+ e-
> launch
> set pdlabel cteq6l1
> launch
> set pdlabel lhapd
> set lhaid 70251
>
>
> Cheers,
>
> Olivier
> --
>
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.1.2-lhapdf6/+merge/231518
> Your team MadDevelopers is subscribed to branch
> lp:~maddevelopers/mg5amcnlo/2.1.3.
>