Code review comment for lp:~maddevelopers/mg5amcnlo/1.5.8

Revision history for this message
Johan Alwall (johan-alwall) wrote :

Hello Olivier,

> OM: Fix a bug in model restriction when a width was equals to one.
> In such case, the width is not fixed to this value anymore.

Regarding the model restrictions, I just realized that at some point a very serious bug has been introduced. If two particles have identical masses and widths, both masses and widths should be identified (whereas, if only widths are identical but not masses, we could discuss that they should not since this can only be a coincidence). This used to be the case for the default restriction card of the mssm, but it doesn't work anymore.

In fact, this is the reason why there was a problem with huge numbers of matrix elements for an MSSM decay process. So this is a very serious bug for mssm. I'm pretty sure I haven't reviewed such a change, so I don't know when it was introduced.

I'll continue looking at the code now.

Cheers,
Johan

review: Needs Fixing

« Back to merge proposal