Unity 8

Code review comment for lp:~macslow/unity8/use-set-progress-api

  1. use-set-progress-api
  2. Merge into trunk
Revision history for this message
Michael Zanetti (mzanetti) wrote :

As I commented on the related unity-api branch, I don't think we need to define an API for that. Unity8 itself doesn't ever set the progress.

* You can then completely revert the change in launchermodeas.

* I haven't tested it yet, but reading through the code it seems you didn't wire up the Set method on D-Bus.

* in asadapter.cpp you need to sync the progress value to AS too.

* in launchermodelas.cpp you need to read the change from AS and set that to the LauncherItems

review: Needs Fixing

« Back to merge proposal