Code review comment for lp:~macslow/unity8/synchronous-notification

Revision history for this message
Albert Astals Cid (aacid) wrote :

Code looks good, tests look good and the example python application to exercise the code looks good.

Could not try the volume integration since it's still not done, but assuming it is using the same codepath as the example python application i think this is good to go.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Unrelated broken autopilot

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

« Back to merge proposal