Unity 8

Code review comment for lp:~macslow/unity8/synchronous-notification

  1. synchronous-notification
  2. Merge into trunk
Revision history for this message
Albert Astals Cid (aacid) wrote :

Should

  implicitHeight: type !== Notification.PlaceHolder ? (fullscreen ? maxHeight : outterColumn.height - (type === Notification.Confirmation ? units.gu(.5) : 0) + contentSpacing * 2) : 0

be

  implicitHeight: type !== Notification.PlaceHolder ? (fullscreen ? maxHeight : outterColumn.height - shapedBack.topMargin + contentSpacing * 2) : 0

?

review: Needs Information

« Back to merge proposal