Code review comment for lp:~macslow/unity8/shellRotation

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

Got one failure:

unity8.shell.tests.test_rotation.TestFakeSensor.test_fake_sensor(right up)

08:11:58.733 WARNING testcase:175 - Process manager backend unavailable, application snapshot support disabled.
08:11:58.742 WARNING utilities:263 - WARNING: in file "/usr/lib/python3/dist-packages/unity8/shell/tests/__init__.py", line 140 in setUp
This function is deprecated. Please use 'the Touch class to instantiate a device object' instead.

08:11:58.895 INFO logging:45 - str: Set the value of an initctl environment variable. Arguments ('sensors',). Keyword arguments: {'global_': False}.
08:11:59.095 INFO process_helpers:177 - Starting job unity8 with arguments ('BINARY=/usr/bin/unity8', 'XDG_DATA_DIRS=/usr/share/unity8/mocks/data:/usr/share/ubuntu-touch:/usr/local/share:/usr/share', 'LD_LIBRARY_PATH=/usr/lib/arm-linux-gnueabihf/unity8/qml/mocks/libusermetrics:/usr/lib/arm-linux-gnueabihf/unity8/qml/mocks/LightDM/liblightdm:/vendor/lib:/system/lib', 'QML2_IMPORT_PATH=/usr/lib/arm-linux-gnueabihf/unity8/qml/mocks:/usr/lib/arm-linux-gnueabihf/qt5/imports', 'QT_LOAD_TESTABILITY=1').
08:12:00.433 INFO process_helpers:185 - unity8 start/running, process 17721

08:12:08.997 INFO process_helpers:88 - Greeter unlocked, continuing.
08:12:26.943 INFO process_helpers:233 - Stoping job unity8.
08:12:29.006 INFO process_helpers:241 - unity8 stop/waiting

08:12:29.009 INFO logging:45 - str: Remove an initctl environment variable. Arguments (). Keyword arguments: {'global_': False}.

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/unity8/shell/tests/test_rotation.py", line 67, in test_fake_sensor
    Eventually(Equals(self.orientation), timeout=15))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 423, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: After 15.0 seconds test on OrientedShell.physicalOrientation failed: 8 != dbus.Int32(2, variant_level=1)

review: Needs Fixing

« Back to merge proposal