Code review comment for lp:~macslow/unity/unity-4.0.fix-834630

Revision history for this message
Tim Penhey (thumper) wrote :

I think it would be slightly clearer with:
  if (detail_selection_index >= DetailXids().size())
rather than:
  if (detail_selection_index > DetailXids().size() - 1)

as normally when looping you have
  while (index < size)
and the opposite of < is >=

What do you think?

review: Approve

« Back to merge proposal