Code review comment for lp:~macslow/unity/phablet-notification-renderer

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

Hey, some last still-remaining tweaks:

=====

 77 + spacing: units.gu(1)

Should be contentColumn.spacing

=====

 58 + enabled: type == "Notifications.Type.Interactive"

150 + visible: type == "Notifications.Type.SnapDecision"

157 + model: actions

Should be notification.type ==, notification.actions

=====

162 + width: (topRow.width - buttonRow.spacing) / 2

Why topRow? Shouldn't this be buttonRow.width?

=====

That's it.

review: Needs Fixing

« Back to merge proposal