Code review comment for lp:~macslow/unity/phablet-notification-renderer

Revision history for this message
Michael Zanetti (mzanetti) wrote :

604 + wait(100)

really required? I know only because view.count == model.count it doesn't mean that the delegates are created already. I think still wait(0) should be enough. (Fine as long it is set to WIP - just wanted to mention it for completemess)

* Regarding the if() around the signal spys: I think it would be better to add the conditions to the test data. Because if you decide on interactiveArea.visible, your test wouldn't catch a bug where interactiveArea is already visible by mistake. Better extending testdata with data like "isInteractive: true; hasButtons: false"

review: Needs Fixing

« Back to merge proposal