Code review comment for lp:~macslow/unity/phablet-notification-renderer

Revision history for this message
Mirco Müller (macslow) wrote :

All mentioned suggestions were addressed, with two variations:

* I left the explicit sizes for icon and secondary-icon in place as a "safty-net", for those cases when rogue applications pass in too small or too large icons, thus the layout of the notification does not break away from the design-guideline.

* With the way anchors are used in summayLabel and bodyLabel now, there's no danger of them being accidentally placed next to each other.

Good to merge with trunk?

« Back to merge proposal