Code review comment for lp:~macslow/unity/phablet-notification-renderer

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

Sure, that's a valid concern. QML Notification component would end up as a QQmlNotification in C++ world, and anyway namespacing is helping here - it's going to be Unity::Notifications::Notification in C++ world. And even in QML it's recommended to used named imports (import Unity.Notifications 0.1 as Notifications) and then the components exposed from that plugin are available as Notifications.Notification, for example.

What's more, we'll never use (title case) Notification as exposed from the QML Unity.Notifications plugin, at least not in the shell. That object will only be created C++ side.

So, all in all I don't foresee naming conflicts, but to avoid confusion, I could agree to a different name ;). I'd like to avoid "Bubble" nevertheless ;D

« Back to merge proposal