Code review comment for lp:~macslow/unity-notifications/fix-1295762

Revision history for this message
Lars Karlitski (larsu) wrote :

> Since this is meant to only address the timeout of snap-decisions
> notifications, the standard libnotify-way of stating a custom timeout -
> applied to any type of notification - has intentionally not been chosen.

A snap decision is just a normal notification? Why can't we just reuse the standard expiration timeout, which is not used for anything now.

As for the bug that is supposedely fixing: shouldn't indicator-network simply pass 0 as timeout to get have the bubble stay on screen until the user interacts with it?

review: Disapprove

« Back to merge proposal