Code review comment for lp:~macslow/nux/nux.metrics

 Copyright (C) 2011 Canonical Ltd

2012...

---

+#include "config.h"

Is this really needed?

---

57 + xres = ((((double) DisplayWidth(dpy,scr)) * 25.4) /
58 + ((double) DisplayWidthMM(dpy,scr)));
59 + yres = ((((double) DisplayHeight(dpy,scr)) * 25.4) /
60 + ((double) DisplayHeightMM(dpy,scr)));

C style cast... :(

---

+ Metrics::~Metrics ()
73 + {
74 + }

It doesn nothing, so remove it :)

---

110 +#ifndef METRICS_H
111 +#define METRICS_H

Should be NUX_MET..

---

+#include <X11/Xlib.h>

I'd prefer a fwd declaration for Display if it is possible.

---

Ah, no spaces between the function name and the bracket. And you've not pushed the unit-test :)

P.S. I'm not marking it as Need Fixing because these "issues" are not blocking.