Code review comment for lp:~macslow/notify-osd/shave-support

Revision history for this message
Neil J. Patel (njpatel) wrote :

I don't think you should use shave anymore...automake1.11 is part of Karmic and it supports silent make by just adding:

m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])

to the configure.ac (directly below AM_INIT_AUTOMAKE()). This will revert to the normal output if the user is using < automake 1.11.

Custom silent rules are done using AM_V_GEN and AM_V_CC (see http://www.flameeyes.eu/autotools-mythbuster/automake/silent.html).

I currently use Shave across most of the UNR projects, but I'm aiming to move completely to automake's version soon.

review: Disapprove

« Back to merge proposal